fix backtrace filtering in failed testsets #23998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
changed the title
KristofferC
force-pushed
the
kc/fix_filter_bt
branch
from
e93fd30 to
76d2648
Compare
KristofferC
force-pushed
the
kc/fix_filter_bt
branch
from
76d2648 to
74936a6
Compare
tkelman
reviewed
Oct 6, 2017
| @test_broken !contains(str, "client.jl") | ||
| end | ||
| end | ||
| f = tempname() |
There was a problem hiding this comment.
should delete this when done, or use a mktemp do block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also rewrite the test a bit to be more similar to how it is used in practice.
We'll see if this needs some path normalization.